fix(generator): Output Parser.parseItem() calls with one valid type, without the array #551
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without the array
LuanRT
approved these changes
Dec 4, 2023
Wykerd
added a commit
that referenced
this pull request
Dec 11, 2023
Add Parser#parse overload to support non array validTypes. Fixes issue in generator generating invalid Parser#parse calls introduced in #551.
LuanRT
pushed a commit
that referenced
this pull request
Dec 21, 2023
* feat(generator): add support for arrays * fix(parser): add overload for non array validTypes Add Parser#parse overload to support non array validTypes. Fixes issue in generator generating invalid Parser#parse calls introduced in #551.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is only one valid type being passed to
Parser.parseItemorParser.parse, it can be passed directly without being wrapped in an array, this pull request changes the generated output to only use an array when it is needed.